From 135a65e200d372dd31f19639d25c9b5aa1459252 Mon Sep 17 00:00:00 2001 From: Giuseppe Bilotta Date: Fri, 9 Dec 2011 11:20:19 +0100 Subject: [PATCH] Add virtual destructors to abstract classes IRespawnInitiator and InventoryActions are abstract classes, but they were missing a virtual destructor. Define it, even if it does nothing and its absence most likely makes no difference other tha causing warnings during compile. --- src/guiDeathScreen.h | 1 + src/guiTextInputMenu.h | 1 + src/inventory.h | 3 ++- 3 files changed, 4 insertions(+), 1 deletion(-) diff --git a/src/guiDeathScreen.h b/src/guiDeathScreen.h index 10a97d7e..54cc49b0 100644 --- a/src/guiDeathScreen.h +++ b/src/guiDeathScreen.h @@ -29,6 +29,7 @@ class IRespawnInitiator { public: virtual void respawn() = 0; + virtual ~IRespawnInitiator() {}; }; class GUIDeathScreen : public GUIModalMenu diff --git a/src/guiTextInputMenu.h b/src/guiTextInputMenu.h index c679aa9c..2939cf65 100644 --- a/src/guiTextInputMenu.h +++ b/src/guiTextInputMenu.h @@ -28,6 +28,7 @@ with this program; if not, write to the Free Software Foundation, Inc., struct TextDest { virtual void gotText(std::wstring text) = 0; + virtual ~TextDest() {}; }; class GUITextInputMenu : public GUIModalMenu diff --git a/src/inventory.h b/src/inventory.h index c16b9a31..795d32d3 100644 --- a/src/inventory.h +++ b/src/inventory.h @@ -554,11 +554,12 @@ public: struct InventoryAction { static InventoryAction * deSerialize(std::istream &is); - + virtual u16 getType() const = 0; virtual void serialize(std::ostream &os) const = 0; virtual void apply(InventoryContext *c, InventoryManager *mgr, ServerEnvironment *env) = 0; + virtual ~InventoryAction() {}; }; struct IMoveAction : public InventoryAction -- 2.30.2