From: Perttu Ahola <celeron55@gmail.com>
Date: Sat, 30 Jul 2011 23:27:26 +0000 (+0300)
Subject: Made stricter handling for old clients because now they are not compatible at all.
X-Git-Url: http://81.2.79.47:8989/gitweb/?a=commitdiff_plain;h=756f8f88d4c127917cc9ea77e2e44606c199beed;p=zefram%2Fminetest%2Fminetest_engine.git

Made stricter handling for old clients because now they are not compatible at all.
---

diff --git a/src/server.cpp b/src/server.cpp
index 503d60b8..ba40ec62 100644
--- a/src/server.cpp
+++ b/src/server.cpp
@@ -1972,20 +1972,23 @@ void Server::ProcessData(u8 *data, u32 datasize, u16 peer_id)
 		}
 		
 		/*
-			Check network protocol version
+			Read and check network protocol version
 		*/
+
 		u16 net_proto_version = 0;
 		if(datasize >= 2+1+PLAYERNAME_SIZE+PASSWORD_SIZE+2)
 		{
 			net_proto_version = readU16(&data[2+1+PLAYERNAME_SIZE+PASSWORD_SIZE]);
 		}
+
 		getClient(peer->id)->net_proto_version = net_proto_version;
-		/*if(net_proto_version == 0)
+
+		if(net_proto_version == 0)
 		{
 			SendAccessDenied(m_con, peer_id,
-					L"Your client is too old (network protocol)");
+					L"Your client is too old. Please upgrade.");
 			return;
-		}*/
+		}
 
 		/*
 			Set up player
@@ -2181,11 +2184,12 @@ void Server::ProcessData(u8 *data, u32 datasize, u16 peer_id)
 			message += L" joined game";
 			BroadcastChatMessage(message);
 		}
-
-		if(getClient(peer->id)->net_proto_version == 0)
+		
+		// Warnings about protocol version can be issued here
+		/*if(getClient(peer->id)->net_proto_version == 0)
 		{
 			SendChatMessage(peer_id, L"# Server: NOTE: YOUR CLIENT IS OLD AND DOES NOT WORK PROPERLY WITH THIS SERVER");
-		}
+		}*/
 
 		return;
 	}